Use append_cflags instead of modifying CFLAGS directly#29
Merged
cabo merged 2 commits intocabo:masterfrom Aug 2, 2025
Merged
Conversation
This was referenced Jul 23, 2025
Closed
nethad
reviewed
Jul 28, 2025
This fixes a compilation issue in GCC 15 due `stdbool.h` not being included when `-std=c99` is in use. This occurs because the standard `configure` script shipped with Ruby does not properly test for `stdbool.h` on C23 compilers. It needs to pick up this change: https://cgit.git.savannah.gnu.org/cgit/autoconf.git/commit/?id=6dcecb780a69bd208088d666b299e92aa7ae7e80 The `append_cflags` approach is recommended over modifying CFLAGS since it ensures compatibility across different build environments by checking whether the flag is acceptable. Similar changes: * socketry/io-event#137 * mongodb/bson-ruby#355 Closes cabo#27
Contributor
Author
|
@cabo Would you mind reviewing this? Thank you! |
Owner
Still on vacation this week. Planning to do this this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a compilation issue in GCC 15 due
stdbool.hnot being included when-std=c99is in use. This occurs because the standardconfigurescript shipped with Ruby does not properly test forstdbool.hon C23 compilers (https://bugs.ruby-lang.org/issues/21340). It needs to pick up this change:https://cgit.git.savannah.gnu.org/cgit/autoconf.git/commit/?id=6dcecb780a69bd208088d666b299e92aa7ae7e80
The
append_cflagsapproach is recommended over modifying CFLAGS since it ensures compatibility across different build environments by checking whether the flag is acceptable.Similar changes:
Closes #27