feat: mapping slice of complex struct#312
Conversation
|
LGTM |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 429 498 +69
=========================================
+ Hits 429 498 +69 ☔ View full report in Codecov by Sentry. |
|
/cc @caarlos0 PTAL, thanks |
|
Hi @caarlos0, could you please review this PR when you have a moment? I am happy to make any changes if needed. Thank you! |
caarlos0
left a comment
There was a problem hiding this comment.
hey, it looks to me!
sorry for the delay reviewing.
I think the only thing missing is something in the readme?
PS: I know the readme is already convoluted, I need to clean it up at some point.
|
Hey, Happy to hear that |
# Conflicts: # env_test.go
|
Dear @caarlos0, I added a sample to the readme. Please check it up when you can |
|
many thanks, this looks great! |
* feat: mapping slice of complex struct caarlos0#298 * feat: support predefined values and pre initialized structs * refactor: some improvement * refactor: some improvement * test: support normal features for nested fields * test: trying to fix `gofumpt` lint issues * chore: add sample for complex struct in readme --------- Co-authored-by: Hamid Reza Ranjbar <hamidreza.ranjbar@snapp.cab>
feat: mapping slice of complex struct. #298