Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f6bb22) 100.00% compared to head (15384ec) 100.00%.

@@            Coverage Diff            @@
##              main      #272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          430       431    +1     
=========================================
+ Hits           430       431    +1     

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

fwiw you can already do this by creating a type wrapping the intended type, and implementing a custom wrapper for it, e.g.:

type MyDuration time.Duration

func (t *MyDuration) UnmarshalText(text []byte) error {
	sec, err := strconv.ParseInt(string(text), 10, 64)
	if err == nil {
		*t = MyDuration(time.Duration(sec) * time.Second)
		return nil
	}
	tt, err := time.ParseDuration(string(text))
	*t = MyDuration(tt)
	return err
}

func TestCustomDurationParser(t *testing.T) {
	type config struct {
		Dur1 MyDuration `env:"DUR_1"`
		Dur2 MyDuration `env:"DUR_2"`
	}

	t.Setenv("DUR_1", "20m")
	t.Setenv("DUR_2", "10")

	var cfg config
	isNoErr(t, Parse(&cfg))
	isEqual(t, time.Duration(cfg.Dur1), 20*time.Minute)
	isEqual(t, time.Duration(cfg.Dur2), 10*time.Second)
}

fwiw you can already do this by creating a type wrapping the intended type, and implementing a custom wrapper for it, e.g.:

type MyDuration time.Duration

func (t *MyDuration) UnmarshalText(text []byte) error {
	sec, err := strconv.ParseInt(string(text), 10, 64)
	if err == nil {
		*t = MyDuration(time.Duration(sec) * time.Second)
		return nil
	}
	tt, err := time.ParseDuration(string(text))
	*t = MyDuration(tt)
	return err
}

func TestCustomDurationParser(t *testing.T) {
	type config struct {
		Dur1 MyDuration `env:"DUR_1"`
		Dur2 MyDuration `env:"DUR_2"`
	}

	t.Setenv("DUR_1", "20m")
	t.Setenv("DUR_2", "10")

	var cfg config
	isNoErr(t, Parse(&cfg))
	isEqual(t, time.Duration(cfg.Dur1), 20*time.Minute)
	isEqual(t, time.Duration(cfg.Dur2), 10*time.Second)
}

Yes I can
But if I use some external function with time.Duration signature it requires me to always do something like

type MyDuration time.Duration

func (md MyDuration) ToDuration() time.Duration {
	return time.Duration(md)
}

func doSomething(duration time.Duration) {
	fmt.Println(duration)
}

doSomething(value.ToDuration())

or

doSomething(time.Duration(value))

Or parse my own type separately from the main struct and use ToDuration() and store in the struct, which is a bit awkward in my opinion

And if I want to use it in combination with flag I have to implement String() and Set() methods in MyDuration for flag.Var() instead of using flag.DurationVar() (flag.DurationVar works with numbers without any customization)

And BTW the defaultTypeParsers from the var name hints to me that I should be able to use something custom if I want to :)

yeah, you right.

all right, let's merge this, but it'll be a breaking change.