Add fuzzer input files that trigger problems#263
Closed
daviddrysdale wants to merge 2 commits intoc-ares:masterfrom
Closed
Add fuzzer input files that trigger problems#263daviddrysdale wants to merge 2 commits intoc-ares:masterfrom
daviddrysdale wants to merge 2 commits intoc-ares:masterfrom
Conversation
Suspect problems were introduced by 7d3591e ("getaddrinfo enhancements (c-ares#257)"), and include: - ares_parse_a_reply.c:170 : WRITE stack buffer overflow - ares_parse_aaaa_reply.c:170,172 : WRITE stack buffer overflow - ares_parse_a_reply:149 : leak - ares_parse_aaaa_reply.c:151 : leak Reproduce by building with ASAN enabled and running (e.g.): ./test/aresfuzz ./test/fuzzinput/clusterfuzz-5650695891451904
Contributor
|
@daviddrysdale took the files into #264 along with the fix |
bradh352
pushed a commit
that referenced
this pull request
Jun 24, 2019
* fix leak if naddress of particular type found * fix segfault when wanted ttls count lesser than count of result records * add fuzzer input files that trigger problems (from #263) Reported-By: David Drysdale (@daviddrysdale) Fix-By: Andrew Selivanov (@ki11roy)
Member
|
@daviddrysdale ok to close? |
Member
Author
|
Yep, looks like all the fuzzer cases are now verified as fixed. |
vadorovsky
pushed a commit
to vadorovsky/c-ares
that referenced
this pull request
Nov 1, 2019
* fix leak if naddress of particular type found * fix segfault when wanted ttls count lesser than count of result records * add fuzzer input files that trigger problems (from c-ares#263) Reported-By: David Drysdale (@daviddrysdale) Fix-By: Andrew Selivanov (@ki11roy)
DronRathore
pushed a commit
to DronRathore/c-ares
that referenced
this pull request
Mar 11, 2020
* fix leak if naddress of particular type found * fix segfault when wanted ttls count lesser than count of result records * add fuzzer input files that trigger problems (from c-ares#263) Reported-By: David Drysdale (@daviddrysdale) Fix-By: Andrew Selivanov (@ki11roy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suspect problems were introduced by 7d3591e ("getaddrinfo
enhancements (#257)"), and revolve around:
Reproduce by building with ASAN enabled and running (e.g.):
./test/aresfuzz ./test/fuzzinput/clusterfuzz-5650695891451904