Store one fiber stack in a Store<T>#9604
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Nov 14, 2024
Merged
Conversation
This commit stores a single fiber stack in `Store<T>` as a cache to be used throughout the lifetime of the `Store`. This should help amortize the cost of allocating a stack for use in a store because the same stack can be used continuously throughout the lifetime of the `Store<T>`. This notably reduces contention on the lock used to manage the pooling allocator when possible.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jan 14, 2025
This commit fixes a regression from bytecodealliance#9604 where using `Store::into_data` wouldn't properly drop a cached stack in a store like a `Drop` destructor. The fix here is to add the `flush_fiber_stack` method into the `into_data` here as well.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
This commit fixes a regression from #9604 where using `Store::into_data` wouldn't properly drop a cached stack in a store like a `Drop` destructor. The fix here is to add the `flush_fiber_stack` method into the `into_data` here as well.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jan 14, 2025
…0009) This commit fixes a regression from bytecodealliance#9604 where using `Store::into_data` wouldn't properly drop a cached stack in a store like a `Drop` destructor. The fix here is to add the `flush_fiber_stack` method into the `into_data` here as well.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jan 14, 2025
…0009) This commit fixes a regression from bytecodealliance#9604 where using `Store::into_data` wouldn't properly drop a cached stack in a store like a `Drop` destructor. The fix here is to add the `flush_fiber_stack` method into the `into_data` here as well.
alexcrichton
added a commit
that referenced
this pull request
Jan 14, 2025
This commit fixes a regression from #9604 where using `Store::into_data` wouldn't properly drop a cached stack in a store like a `Drop` destructor. The fix here is to add the `flush_fiber_stack` method into the `into_data` here as well.
alexcrichton
added a commit
that referenced
this pull request
Jan 14, 2025
This commit fixes a regression from #9604 where using `Store::into_data` wouldn't properly drop a cached stack in a store like a `Drop` destructor. The fix here is to add the `flush_fiber_stack` method into the `into_data` here as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit stores a single fiber stack in
Store<T>as a cache to be used throughout the lifetime of theStore. This should help amortize the cost of allocating a stack for use in a store because the same stack can be used continuously throughout the lifetime of theStore<T>. This notably reduces contention on the lock used to manage the pooling allocator when possible.