test-macros: Handle dead code warnings#9492
Merged
saulecabrera merged 1 commit intobytecodealliance:mainfrom Oct 22, 2024
Merged
test-macros: Handle dead code warnings#9492saulecabrera merged 1 commit intobytecodealliance:mainfrom
saulecabrera merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit handles dead code warnings produced by the compiler when the
macro is invoked as:
#[wasmtime_test(strategies(not(Cranelift))]
Which occur because Winch currently only offers support for x86_64.
The motivation behind this change comes from
bytecodealliance#9490, which is where
the warnings surfaced.
alexcrichton
approved these changes
Oct 22, 2024
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Oct 22, 2024
After poking around with APIs a bit this is a minor evolution of bytecodealliance#9492 to always run Winch tests, even if they're expected to fail, but failure is allowed if they're expected to fail. This is done via the `Termination` trait and inspecting the `ExitCode` that it returns to assert that it has the relevant exit code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit handles dead code warnings produced by the compiler when the macro is invoked as:
Which occur because Winch currently only offers support for x86_64.
The motivation behind this change comes from
#9490, which is where the warnings surfaced.