Update zstd dependency#7870
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Feb 5, 2024
Merged
Conversation
Looks like it's been awhile since our last update. I've updated the dependency here and additionally vetted the various dependency upgrades. I notably did not vet `zstd-sys` since that would require vetting all of zstd's C implementation itself which I am not, nor do I suspect many of are, equipped to do. In lieu of that I've updated the exemption of `zstd-sys` to the newer version. Closes bytecodealliance#7869
pchickey
approved these changes
Feb 5, 2024
jameysharp
added a commit
to jameysharp/wasmtime
that referenced
this pull request
Apr 1, 2024
When I tried to audit our previous exemption for zstd, I found two buffer overruns which were reachable from safe Rust, although not reachable from Wasmtime. I got them fixed upstream but didn't update our cargo-vet audits to reflect the issue with the older versions. Alex updated our dependencies to pull in the fixed versions in bytecodealliance#7870, and this PR notes for the benefit of anyone importing the Bytecode Alliance audit set that older versions should not be used. See gyscos/zstd-rs#231
jameysharp
added a commit
to jameysharp/wasmtime
that referenced
this pull request
Aug 26, 2024
When I tried to audit our previous exemption for zstd, I found two buffer overruns which were reachable from safe Rust, although not reachable from Wasmtime. I got them fixed upstream but didn't update our cargo-vet audits to reflect the issue with the older versions. Alex updated our dependencies to pull in the fixed versions in bytecodealliance#7870, and this PR notes for the benefit of anyone importing the Bytecode Alliance audit set that older versions should not be used. See gyscos/zstd-rs#231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like it's been awhile since our last update. I've updated the dependency here and additionally vetted the various dependency upgrades. I notably did not vet
zstd-syssince that would require vetting all of zstd's C implementation itself which I am not, nor do I suspect many of are, equipped to do. In lieu of that I've updated the exemption ofzstd-systo the newer version.Closes #7869