Skip to content

dep: target-lexicon: 0.12.3 -> 0.12.12#7378

Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom
near:nagisa/upgrades-target-lexicon
Oct 30, 2023
Merged

dep: target-lexicon: 0.12.3 -> 0.12.12#7378
alexcrichton merged 1 commit intobytecodealliance:mainfrom
near:nagisa/upgrades-target-lexicon

Conversation

@nagisa
Copy link
Copy Markdown
Contributor

@nagisa nagisa commented Oct 26, 2023

Largely just additions of new targets and such, as well as support for serde.

I personally am motivated to make this change, as the downstream development we’re doing depends on the target added in 0.12.12.

@nagisa nagisa requested a review from a team as a code owner October 26, 2023 14:38
@nagisa nagisa requested review from fitzgen and removed request for a team October 26, 2023 14:38
alexcrichton added a commit to alexcrichton/wasmtime that referenced this pull request Oct 26, 2023
@alexcrichton
Add audit for target-lexicon upgrade
a2bb3a4 
Added for bytecodealliance#7378
@alexcrichton alexcrichton mentioned this pull request Oct 26, 2023
Merged
@alexcrichton
Copy link
Copy Markdown
Member

alexcrichton commented Oct 26, 2023

Thanks! For cargo vet I've send a PR with the audit for this at #7380 and once that's landed you can rebase this on that and we can merge

github-merge-queue bot pushed a commit that referenced this pull request Oct 26, 2023
@alexcrichton
Add audit for target-lexicon upgrade (#7380)
0864eb0 
Added for #7378
@nagisa nagisa force-pushed the nagisa/upgrades-target-lexicon branch 2 times, most recently from 2ae43e6 to 85417d8 Compare October 27, 2023 13:41
@nagisa
Copy link
Copy Markdown
Contributor Author

nagisa commented Oct 27, 2023

Hmph, cargo vet is still failing in the CI, even though locally it works perfectly fine now 😕

@alexcrichton
Copy link
Copy Markdown
Member

alexcrichton commented Oct 27, 2023

Apologies that's my bad, I opened #7391 to re-add the vet after I accidentally deleted it.

Note that cargo vet locally is probably automatically re-adding the entry, I think you'll need cargo vet --locked to reproduce the failure on CI

@nagisa nagisa force-pushed the nagisa/upgrades-target-lexicon branch from 85417d8 to e9c3383 Compare October 30, 2023 19:33
@nagisa
dep: target-lexicon: 0.12.3 -> 0.12.12
3819f74 
Largely just additions of new targets and such, as well as support for
serde.
@nagisa nagisa force-pushed the nagisa/upgrades-target-lexicon branch from e9c3383 to 3819f74 Compare October 30, 2023 20:49
@nagisa nagisa requested a review from a team as a code owner October 30, 2023 20:49
@alexcrichton alexcrichton added this pull request to the merge queue Oct 30, 2023
Merged via the queue into bytecodealliance:main with commit e21e3ab Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@fitzgen fitzgen Awaiting requested review from fitzgen fitzgen is a code owner automatically assigned from bytecodealliance/wasmtime-default-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nagisa @alexcrichton