cranelift: don't enable trace-log feature by default#6549
Merged
jameysharp merged 1 commit intobytecodealliance:mainfrom Jun 9, 2023
Merged
cranelift: don't enable trace-log feature by default#6549jameysharp merged 1 commit intobytecodealliance:mainfrom
jameysharp merged 1 commit intobytecodealliance:mainfrom
Conversation
In bytecodealliance#5382 ("egraph support: rewrite to work in terms of CLIF data structures"), we added the `trace-log` feature to the set of default features for `cranelift-codegen`. I think this was an accident, probably added while debugging and overlooked when cleaning up to merge. So let's undo that change. Fixes bytecodealliance#6548.
Contributor
|
thanks! we would love to have this in backported to a patch release of latest version as we saw it being a major bottleneck |
abrown
approved these changes
Jun 9, 2023
fitzgen
approved these changes
Jun 9, 2023
jameysharp
added a commit
to jameysharp/wasmtime
that referenced
this pull request
Jun 9, 2023
…e#6549) In bytecodealliance#5382 ("egraph support: rewrite to work in terms of CLIF data structures"), we added the `trace-log` feature to the set of default features for `cranelift-codegen`. I think this was an accident, probably added while debugging and overlooked when cleaning up to merge. So let's undo that change. Fixes bytecodealliance#6548.
jameysharp
added a commit
to jameysharp/wasmtime
that referenced
this pull request
Jun 9, 2023
…e#6549) In bytecodealliance#5382 ("egraph support: rewrite to work in terms of CLIF data structures"), we added the `trace-log` feature to the set of default features for `cranelift-codegen`. I think this was an accident, probably added while debugging and overlooked when cleaning up to merge. So let's undo that change. Fixes bytecodealliance#6548.
Contributor
Author
|
Since you've asked for it, I've opened #6553 for backporting this to 9.0. I plan to do a point release with this fix included next week. |
alexcrichton
pushed a commit
that referenced
this pull request
Jun 12, 2023
In #5382 ("egraph support: rewrite to work in terms of CLIF data structures"), we added the `trace-log` feature to the set of default features for `cranelift-codegen`. I think this was an accident, probably added while debugging and overlooked when cleaning up to merge. So let's undo that change. Fixes #6548.
jameysharp
added a commit
to jameysharp/wasmtime
that referenced
this pull request
Jun 12, 2023
…e#6549) In bytecodealliance#5382 ("egraph support: rewrite to work in terms of CLIF data structures"), we added the `trace-log` feature to the set of default features for `cranelift-codegen`. I think this was an accident, probably added while debugging and overlooked when cleaning up to merge. So let's undo that change. Fixes bytecodealliance#6548.
jameysharp
added a commit
that referenced
this pull request
Jun 12, 2023
In #5382 ("egraph support: rewrite to work in terms of CLIF data structures"), we added the `trace-log` feature to the set of default features for `cranelift-codegen`. I think this was an accident, probably added while debugging and overlooked when cleaning up to merge. So let's undo that change. Fixes #6548.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5382 ("egraph support: rewrite to work in terms of CLIF data structures"), we added the
trace-logfeature to the set of default features forcranelift-codegen. I think this was an accident, probably added while debugging and overlooked when cleaning up to merge.So let's undo that change. Fixes #6548.
Does anyone have strong opinions for or against backporting this for the upcoming release?