Skip to content

Rename define_function to define_function_with_control_plane#6165

Merged
cfallin merged 1 commit intobytecodealliance:mainfrom
bjorn3:define_function_ergonomics
Apr 6, 2023
Merged

Rename define_function to define_function_with_control_plane#6165
cfallin merged 1 commit intobytecodealliance:mainfrom
bjorn3:define_function_ergonomics

Conversation

@bjorn3
Copy link
Copy Markdown
Contributor

@bjorn3 bjorn3 commented Apr 6, 2023

And add a define_function convenience function which uses a default control plane.

@bjorn3 bjorn3 requested a review from a team as a code owner April 6, 2023 13:21
@bjorn3 bjorn3 requested review from jameysharp and removed request for a team April 6, 2023 13:21
@bjorn3
Copy link
Copy Markdown
Contributor Author

bjorn3 commented Apr 6, 2023

cc #6039 (comment)

@bjorn3 bjorn3 force-pushed the define_function_ergonomics branch 4 times, most recently from 5662fdc to 9ab5378 Compare April 6, 2023 13:35
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:module labels Apr 6, 2023
And add a define_function convenience function which uses a default
control plane.
@bjorn3 bjorn3 force-pushed the define_function_ergonomics branch from 9ab5378 to 9c2360b Compare April 6, 2023 15:56
@cfallin cfallin self-assigned this Apr 6, 2023
Copy link
Copy Markdown
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks!

@cfallin cfallin enabled auto-merge April 6, 2023 15:58
@cfallin cfallin added this pull request to the merge queue Apr 6, 2023
@bjorn3
Copy link
Copy Markdown
Contributor Author

bjorn3 commented Apr 6, 2023

The riscv64 test job has been running for almost an hour now while CI normally finishes within 40 minutes: https://github.com/bytecodealliance/wasmtime/actions/runs/4630900109/jobs/8193094544 Maybe it is stuck?

Merged via the queue into bytecodealliance:main with commit e1812b6 Apr 6, 2023
@bjorn3 bjorn3 deleted the define_function_ergonomics branch April 6, 2023 18:22
brendandburns pushed a commit to brendandburns/wasmtime that referenced this pull request Apr 13, 2023
…ealliance#6165)

And add a define_function convenience function which uses a default
control plane.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:module cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants