Skip to content

Update dependencies#5513

Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom
a1phyr:update_deps
Feb 14, 2023
Merged

Update dependencies#5513
alexcrichton merged 1 commit intobytecodealliance:mainfrom
a1phyr:update_deps

Conversation

@a1phyr
Copy link
Copy Markdown
Contributor

@a1phyr a1phyr commented Jan 4, 2023

This update dependencies of the project to keep up with the ecosystem

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator wasi Issues pertaining to WASI labels Jan 4, 2023
@alexcrichton
Copy link
Copy Markdown
Member

Thanks for the PR! One thing to note is that we try to be careful about dependencies in Wasmtime, notably we're auditing new dependencies being added. As you've seen this means that dependency updates need to be audited. Additionally we're avoiding adding new exemptions to the audit list, so all updates need to be audited.

While it's ok to update everything here all-at-once, there's a fair amount to audit, so if you'd prefer to split things up into separate PRs I think that would work well too.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 4, 2023

Subscribe to Label Action

cc @kubkon

Details This issue or pull request has been labeled: "cranelift", "wasi"

Thus the following users have been cc'd because of the following labels:

  • kubkon: wasi

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@a1phyr
Copy link
Copy Markdown
Contributor Author

a1phyr commented Jan 5, 2023

Is it ok for you if ahash is left out as an exception for now ? I reviewed all others updates.

Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments below, and thanks again for your help with this!

I'm curious what others think about blanket auditing the usage of crates that are also depended on by libstd. I don't see any particular reason not to per se, but wanted to make sure that didn't raise the eyebrows of others.

@EdorianDark
Copy link
Copy Markdown

Thanks for working on this.

alexcrichton added a commit to alexcrichton/wasmtime that referenced this pull request Feb 14, 2023
This adds vet entries for the updates being performed in bytecodealliance#5513
@alexcrichton
Copy link
Copy Markdown
Member

I apologize for a bit of a runaround on what to do about the cargo vet entries here. We're still experimenting ourselves how best to handle this. We decided a little bit ago that for dependency updates like this what we'll do is that one of the "trusted reviewers" will merge new vet entries into main which the PR can then rebase on top of. To that end I've created #5778 which creates vet entries for the dependencies being pulled in here, so when that merges could you rebase on that to merge?

We independently talked a bit ago about what to do about dependencies transitively used by the standard library and we decided that we would consider updating exemptions based on that but didn't want to record a full audit purely based on the usage in the standard library as well. (mostly just as a heads up, doesn't affect this PR too much with #5778 having all the necessary vet entries)

alexcrichton added a commit that referenced this pull request Feb 14, 2023
This adds vet entries for the updates being performed in #5513
@alexcrichton alexcrichton enabled auto-merge (squash) February 14, 2023 18:49
@alexcrichton alexcrichton merged commit cb150d3 into bytecodealliance:main Feb 14, 2023
@a1phyr a1phyr deleted the update_deps branch June 14, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift Issues related to the Cranelift code generator wasi Issues pertaining to WASI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants