Rename MmapVec::drain to split_off#4673
Merged
alexcrichton merged 3 commits intobytecodealliance:mainfrom Aug 15, 2022
Merged
Conversation
As suggested on bytecodealliance#4609
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Aug 10, 2022
Fixes a build failure on bytecodealliance#4673 where tuples of length 16 don't implement `Debug` from the standard library.
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Aug 11, 2022
Fixes a build failure on bytecodealliance#4673 where tuples of length 16 don't implement `Debug` from the standard library.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Aug 11, 2022
Fixes a build failure on bytecodealliance#4673 where tuples of length 16 don't implement `Debug` from the standard library.
alexcrichton
added a commit
that referenced
this pull request
Aug 11, 2022
Fixes a build failure on #4673 where tuples of length 16 don't implement `Debug` from the standard library.
Contributor
|
I've pushed an alternative on top of this branch, to exactly match the behavior of |
Member
Author
|
Looks good to me! It also looks like github is smart enough to prevent me from approving my own PR, so I'll need your stamp as well for the merge. |
jameysharp
approved these changes
Aug 15, 2022
Contributor
jameysharp
left a comment
There was a problem hiding this comment.
Curse your excessive cleverness, GitHub! 😂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested on #4609