Replace InsertLane format with TernaryImm8#1762
Replace InsertLane format with TernaryImm8#1762abrown wants to merge 1 commit intobytecodealliance:masterfrom
Conversation
|
I am also thinking of doing the same for |
Subscribe to Label Actioncc @bnjbvr DetailsThis issue or pull request has been labeled: "cranelift", "cranelift:meta", "cranelift:wasm"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
The InsertLane format has an ordering (`value().imm().value()`) and immediate name (`"lane"`) that make it awkward to use for other instructions. This changes the ordering (`value().value().imm()`) and uses the default name (`"imm"`) throughout the codebase.
Like bytecodealliance#1762, this change the name of the `ExtractLane` format to the more-general `BinaryImm8` and renames its immediate argument from `lane` to `imm`.
|
I feel it's important to note here that this is a pretty x86-oriented change - edit: NEON instructions would go through the new backend machinery anyway, so that question isn't so relevant. I don't want to single-handedly encourage orienting the old backend machinery towards x86, so: this seems like a fair change in considering other |
Like bytecodealliance#1762, this change the name of the `ExtractLane` format to the more-general `BinaryImm8` and renames its immediate argument from `lane` to `imm`.
Like #1762, this change the name of the `ExtractLane` format to the more-general `BinaryImm8` and renames its immediate argument from `lane` to `imm`.
The InsertLane format has an ordering (
value().imm().value()) and immediate name ("lane") that make it awkward to use for other instructions. This changes the ordering (value().value().imm()) and uses the default name ("imm") throughout the codebase.