Skip to content

Add add_call_site + pass SourceLoc in RelocSink#1460

Merged
bnjbvr merged 2 commits intobytecodealliance:masterfrom
bnjbvr:reloc-sourceloc
Apr 7, 2020
Merged

Add add_call_site + pass SourceLoc in RelocSink#1460
bnjbvr merged 2 commits intobytecodealliance:masterfrom
bnjbvr:reloc-sourceloc

Conversation

@bnjbvr
Copy link
Copy Markdown
Member

@bnjbvr bnjbvr commented Apr 2, 2020

This implements the two first bullet-points of #1453 (motivation of this PR is explained there). This is a separate refactoring that'll make the integration of the new backend easier in Spidermonkey.

@bnjbvr bnjbvr added the cranelift Issues related to the Cranelift code generator label Apr 2, 2020
@bnjbvr bnjbvr requested a review from eqrion April 2, 2020 15:14
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2020

Subscribe to Label Action

This issue or pull request has been labeled: "cranelift"

Users Subscribed to "cranelift"

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@github-actions github-actions bot added cranelift:meta Everything related to the meta-language. cranelift:module labels Apr 2, 2020
Copy link
Copy Markdown
Contributor

@eqrion eqrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bnjbvr
Copy link
Copy Markdown
Member Author

bnjbvr commented Apr 3, 2020

In cfallin#4 (comment), @cfallin suggests to put a default empty impl for CodeSink::add_call_site, which is a sensible idea, so I'll add this too.

@bnjbvr bnjbvr force-pushed the reloc-sourceloc branch from 2a78148 to a844537 Compare April 7, 2020 09:09
@github-actions github-actions bot added the lightbeam Issues related to the Lightbeam compiler label Apr 7, 2020
@bnjbvr bnjbvr merged commit 6a68130 into bytecodealliance:master Apr 7, 2020
@bnjbvr bnjbvr deleted the reloc-sourceloc branch April 7, 2020 09:52
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Apr 7, 2020
…ions; r=rhunt

This goes hand in hand with
bytecodealliance/wasmtime#1460, which will need to be
merged first.

This removes most of the Spidermonkey-specific machinery to collect
relocations. The only remaining place is for stack-maps, which will be handled
later.

Differential Revision: https://phabricator.services.mozilla.com/D69394
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 7, 2020
…ions; r=rhunt

This goes hand in hand with
bytecodealliance/wasmtime#1460, which will need to be
merged first.

This removes most of the Spidermonkey-specific machinery to collect
relocations. The only remaining place is for stack-maps, which will be handled
later.

Differential Revision: https://phabricator.services.mozilla.com/D69394

--HG--
extra : moz-landing-system : lando
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Apr 10, 2020
…ions; r=rhunt

This goes hand in hand with
bytecodealliance/wasmtime#1460, which will need to be
merged first.

This removes most of the Spidermonkey-specific machinery to collect
relocations. The only remaining place is for stack-maps, which will be handled
later.

Differential Revision: https://phabricator.services.mozilla.com/D69394
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 10, 2020
…ions; r=rhunt

This goes hand in hand with
bytecodealliance/wasmtime#1460, which will need to be
merged first.

This removes most of the Spidermonkey-specific machinery to collect
relocations. The only remaining place is for stack-maps, which will be handled
later.

Differential Revision: https://phabricator.services.mozilla.com/D69394

--HG--
extra : moz-landing-system : lando
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this pull request May 1, 2025
…ions; r=rhunt

This goes hand in hand with
bytecodealliance/wasmtime#1460, which will need to be
merged first.

This removes most of the Spidermonkey-specific machinery to collect
relocations. The only remaining place is for stack-maps, which will be handled
later.

Differential Revision: https://phabricator.services.mozilla.com/D69394
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this pull request May 1, 2025
…ions; r=rhunt

This goes hand in hand with
bytecodealliance/wasmtime#1460, which will need to be
merged first.

This removes most of the Spidermonkey-specific machinery to collect
relocations. The only remaining place is for stack-maps, which will be handled
later.

Differential Revision: https://phabricator.services.mozilla.com/D69394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:meta Everything related to the meta-language. cranelift:module cranelift Issues related to the Cranelift code generator lightbeam Issues related to the Lightbeam compiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants