winch: Run more spec tests#11013
Merged
alexcrichton merged 3 commits intobytecodealliance:mainfrom Jun 11, 2025
Merged
Conversation
This commit removes the configuration in Wasmtime indicating that Winch panics on aarch64 with the simd proposal for WebAssembly. This means that many more spec tests can be run by default since they're all, by default, flagged as requiring simd at this time. This in turn means that many more tests needed to be added to the list of "expected to fail" tests for Winch on aarch64 (the ones that actually use simd). One minor panic was fixed as a result of this as well to ensure that tests do indeed run without panicking.
fitzgen
approved these changes
Jun 11, 2025
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
DetailsTo modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
saulecabrera
added a commit
to saulecabrera/wasmtime
that referenced
this pull request
Jun 12, 2025
This commit closes bytecodealliance#8321 With bytecodealliance#11013, Winch passes all spec tests for Core Wasm on Aarch64.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
* winch(aarch64) Run integration tests in winch-aarch64 This commit closes #8321 With #11013, Winch passes all spec tests for Core Wasm on Aarch64. * Run `cargo fmt` * Add an `integration` option to `TestConfig` `wast::TestConfig` is shared across spec tests and integration tests, this commits adds a flag to identify if the config is for integration test purposes making it easier to contextually decide if tests are expected to fail or pass depending on the Wasm configuration options. * Use `spec_test` instead of `integration` To better differentiate spec tests from integration tests * Ensure only aarch64 / x64 when testing Winch * Revert directive for typed_v128 test Put back `#[wasmtime_test(wasm_features(simd), strategies(not(Winch)))]`; the reason why this tests shouldn't run with Winch is because it requires AVX, but we can have a generic rule at the test config level since not all SIMD based tests require AVX, it really depends on which SIMD instructions are used.
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
* winch: Run more spec tests This commit removes the configuration in Wasmtime indicating that Winch panics on aarch64 with the simd proposal for WebAssembly. This means that many more spec tests can be run by default since they're all, by default, flagged as requiring simd at this time. This in turn means that many more tests needed to be added to the list of "expected to fail" tests for Winch on aarch64 (the ones that actually use simd). One minor panic was fixed as a result of this as well to ensure that tests do indeed run without panicking. * Align sp for a few more traps * Update test expectations
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
…ce#11031) * winch(aarch64) Run integration tests in winch-aarch64 This commit closes bytecodealliance#8321 With bytecodealliance#11013, Winch passes all spec tests for Core Wasm on Aarch64. * Run `cargo fmt` * Add an `integration` option to `TestConfig` `wast::TestConfig` is shared across spec tests and integration tests, this commits adds a flag to identify if the config is for integration test purposes making it easier to contextually decide if tests are expected to fail or pass depending on the Wasm configuration options. * Use `spec_test` instead of `integration` To better differentiate spec tests from integration tests * Ensure only aarch64 / x64 when testing Winch * Revert directive for typed_v128 test Put back `#[wasmtime_test(wasm_features(simd), strategies(not(Winch)))]`; the reason why this tests shouldn't run with Winch is because it requires AVX, but we can have a generic rule at the test config level since not all SIMD based tests require AVX, it really depends on which SIMD instructions are used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the configuration in Wasmtime indicating that Winch panics on aarch64 with the simd proposal for WebAssembly. This means that many more spec tests can be run by default since they're all, by default, flagged as requiring simd at this time. This in turn means that many more tests needed to be added to the list of "expected to fail" tests for Winch on aarch64 (the ones that actually use simd). One minor panic was fixed as a result of this as well to ensure that tests do indeed run without panicking.