Responding to review comments re: invoke CLI output and docs#10544
Merged
pchickey merged 1 commit intobytecodealliance:pch/invoke_wavefrom Apr 8, 2025
Merged
Conversation
pchickey
pushed a commit
that referenced
this pull request
Apr 11, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
* wip * invoke works!!! * code motion * more context in errors * fix test of invoke * Invoke wave enhancements (#10511) * wip * wasmtime::component::Component: add iterator of exports * components_rec * exports_rec gives fully qualified name * invoke works!!! * code motion * more context in errors * fix test of invoke * Finalized enhancements for --invoke: error messages * Testing and documenting --invoke * Update if else re: invoke * Updating to fix truncation possibilities in unwrap_tuple * Add clippy annotation to resolve CI error and leave original code (that makes 2 i64 out of 1 i128 and discards extra bits). * Format (rustfmt --edition 2021) Rust files in this PR. * Removing duplicate code missed from previous conflict resolution * Add more verbose documentation * Add more verbose documentation --------- Co-authored-by: Pat Hickey <pat@moreproductive.org> * Convert docs and error trapping to single quote approach (#10533) * Convert docs and error trapping to single quote approach * Adjust the error message a little * Respond to review (#10544) * cli: search component for export items --------- Co-authored-by: Timothy McCallum <mistermac2008@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the CLI output and docs in relation to some review comments from Alex; thanks, Alex.
Below are a few commands, for your convenience, that I ran using the new code (just so you get a sense of the output):
Calling an exported function of a module:
Calling an exported function of a component:
Example of not using WAVE on purpose (when calling exported function of component) so that the error appears: