Improve rendering of errors in wasmtime serve#10282
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Feb 24, 2025
Merged
Improve rendering of errors in wasmtime serve#10282alexcrichton merged 1 commit intobytecodealliance:mainfrom
wasmtime serve#10282alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
For the error from `handle_request` use `e.context(...)` instead of stringifying `e` into a message. Additionally when logging a guest error use `:?` instead of `:#?` to give a more standard `anyhow` rendering of the error.
pchickey
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the error from
handle_requestusee.context(...)instead of stringifyingeinto a message. Additionally when logging a guest error use:?instead of:#?to give a more standardanyhowrendering of the error.