ci: use semicolons for path separation on Windows#10266
Closed
abrown wants to merge 1 commit intobytecodealliance:mainfrom
Closed
ci: use semicolons for path separation on Windows#10266abrown wants to merge 1 commit intobytecodealliance:mainfrom
abrown wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
The new assembler uses `:` to separate a list of paths containing generated code. We received a report that on Windows this could lead to build issues; this change uses `;` for Windows instead. prtest:full
Member
Author
|
It's still pretty unclear to me how this could have got past our Windows CI... |
Member
Author
|
Perhaps something like the following is "fixing up" the paths? wasmtime/.github/workflows/main.yml Lines 29 to 32 in 692490b |
cfallin
approved these changes
Feb 21, 2025
Member
|
This may technically still be broken in cross compilation scenarios due to the os of the build script differing from the os of the target. To sidestep all encoding issues could the array be generated in a rust file in the build script which is included with a macro? |
abrown
added a commit
to abrown/wasmtime
that referenced
this pull request
Feb 21, 2025
This fix is necessary for Windows users who may be using absolute-path target directories: the previous solution, separating the paths by `:`, runs into issues with Windows absolute paths (e.g., `C:\...`). This change is similar to bytecodealliance#10266 but should avoid any further OS compatibility issues during a hypothetical cross-compilation. prtest:full
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
* ci: generate a list of generated files This fix is necessary for Windows users who may be using absolute-path target directories: the previous solution, separating the paths by `:`, runs into issues with Windows absolute paths (e.g., `C:\...`). This change is similar to #10266 but should avoid any further OS compatibility issues during a hypothetical cross-compilation. prtest:full * fix: debug string
Member
|
Superseded by #10267 |
abrown
added a commit
to abrown/wasmtime
that referenced
this pull request
Feb 21, 2025
* ci: generate a list of generated files This fix is necessary for Windows users who may be using absolute-path target directories: the previous solution, separating the paths by `:`, runs into issues with Windows absolute paths (e.g., `C:\...`). This change is similar to bytecodealliance#10266 but should avoid any further OS compatibility issues during a hypothetical cross-compilation. prtest:full * fix: debug string
abrown
added a commit
that referenced
this pull request
Feb 21, 2025
* ci: generate a list of generated files (#10267) * ci: generate a list of generated files This fix is necessary for Windows users who may be using absolute-path target directories: the previous solution, separating the paths by `:`, runs into issues with Windows absolute paths (e.g., `C:\...`). This change is similar to #10266 but should avoid any further OS compatibility issues during a hypothetical cross-compilation. prtest:full * fix: debug string * Add clippy-required annotation * Add vets for recently introduced crates (#10253) CI is currently failing due to missing audits for the following Bytecode Alliance authored crates: * `wasmtime-wasi-io` * `cranelift-assembler-x64` * `cranelift-assembler-meta` * Add release notes for 30.0.1 * Add divider line to release notes --------- Co-authored-by: Saúl Cabrera <saulecabrera@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new assembler uses
:to separate a list of paths containing generated code. We received a report that on Windows this could lead to build issues; this change uses;for Windows instead.prtest:full