Fix a missing increment in p1-to-p2 adapter#10064
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Jan 21, 2025
Merged
Fix a missing increment in p1-to-p2 adapter#10064alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit fixes a bug in the WASIp1-to-WASIp2 adapter during `fd_prestat_dir_name` where an iterator variable was forgotten to be incremented. That means that getting the path for anything other than the first preopen didn't work correctly. Closes bytecodealliance#10058
Member
Author
|
On merging I'm going to backport this to a 29.0.1 release and then use that release to propagate the update of the adapter binary into various bits and pieces of tooling (e.g. wasm-component-ld, rustc, wasi-sdk, cargo-component, etc.) |
rvolosatovs
approved these changes
Jan 21, 2025
dicej
approved these changes
Jan 21, 2025
pchickey
approved these changes
Jan 21, 2025
Contributor
pchickey
left a comment
There was a problem hiding this comment.
C programming, even with Rust syntax, strikes again. Thanks for fixing so quickly. Agree we should patch release where we can.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jan 21, 2025
This commit fixes a bug in the WASIp1-to-WASIp2 adapter during `fd_prestat_dir_name` where an iterator variable was forgotten to be incremented. That means that getting the path for anything other than the first preopen didn't work correctly. Closes bytecodealliance#10058
alexcrichton
added a commit
that referenced
this pull request
Jan 21, 2025
* Add audit for `wasmtime-math` (#10059) I noticed that CI is failing given that an audit and policy for `wasmtime-math` is missing. `wasmtime-math` was introduced in https://github.com/bytecodealliance/wasmtime/pull/9808/files. I followed a similar approach to what it's used for all the other `wasmtime-*` crates. * Fix a missing increment in p1-to-p2 adapter (#10064) This commit fixes a bug in the WASIp1-to-WASIp2 adapter during `fd_prestat_dir_name` where an iterator variable was forgotten to be incremented. That means that getting the path for anything other than the first preopen didn't work correctly. Closes #10058 * Downgrade `wasip2` dep to 0.13.0 Compat with 1.81.0 MSRV --------- Co-authored-by: Saúl Cabrera <saulecabrera@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the WASIp1-to-WASIp2 adapter during
fd_prestat_dir_namewhere an iterator variable was forgotten to be incremented. That means that getting the path for anything other than the first preopen didn't work correctly.Closes #10058