Require root packages when defining nested packages in wit #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f93655 to
c3dd5ec
Compare
Member
alexcrichton
left a comment
There was a problem hiding this comment.
Some initial thoughts jotted down, but I'll hold off on a full review until this is ready.
969724d to
80e7746
Compare
* Remove `&mut` argument, make it owned * Remove new `visit_group` * Refactor `sort_unresolved_groups` and use it in `push_dir` * Fix signature of `push_dir`
* Use a normal AST node for nested packages * Remove some complexity around nested/inlined/etc * Remove some resolver complexity
Merging doesn't work in this location so don't try to handle it.
Member
|
I'll do a final review of this tomorrow and afterwards start to turn the cranks again. |
Test this new feature in the roundtrip fuzzer.
alexcrichton
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial implementation of the wit functionality described here
Now, whenever defining packages as
package {...}, it will be required that some file haspackage namespace:name;as a header somewhere in the project. Thus there is a single root package, and the other package declarations are nested. It also supports intermixing interface and world definitions between nested package definitions across files, and the packages in a deps folder can also nest packages, which are usable by the root package definition and its nested packages