linux-sgx: allow to open files with arbitrary pathes in the sandbox using IPFS. #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing IPFS. A limitation of the current implementation of SGX IPFS in WAMR prevented to open of files which were not in the current directory. This restriction is lifted and can now open files in paths, similarly to the WASI openat call, which takes into account the sandbox of the file system.
wenyongh
reviewed
Nov 6, 2022
…e variable redefinition.
Contributor
Author
|
Hey @wenyongh, Thanks for your insights! I have reviewed, commented and applied the changes. Cheers |
Collaborator
|
@JamesMenetrey Thanks a lot! It is much better now, I will merge the PR after the CI checks finish. |
NingW101
pushed a commit
to NingW101/wasm-micro-runtime
that referenced
this pull request
Dec 1, 2022
…ing IPFS (bytecodealliance#1685) A limitation of the current implementation of SGX IPFS in WAMR is that it prevents to open files which are not in the current directory. This restriction is lifted and can now open files in paths, similarly to the WASI openat call, which takes into account the sandbox of the file system.
wenyongh
pushed a commit
that referenced
this pull request
Dec 6, 2022
…ing IPFS (#1685) A limitation of the current implementation of SGX IPFS in WAMR is that it prevents to open files which are not in the current directory. This restriction is lifted and can now open files in paths, similarly to the WASI openat call, which takes into account the sandbox of the file system.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ing IPFS (bytecodealliance#1685) A limitation of the current implementation of SGX IPFS in WAMR is that it prevents to open files which are not in the current directory. This restriction is lifted and can now open files in paths, similarly to the WASI openat call, which takes into account the sandbox of the file system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
A limitation of the current implementation of SGX IPFS in WAMR prevented to openof files which were not in the current directory. This restriction is lifted and can now open files in paths, similarly to the WASI openat call, which takes into account the sandbox of the file system.
Under the scenes, SGX IPFS retrieves the path of the symbolic link of the file descriptor using
/proc/selfand resolves the path of the opened file usingreadlink.Cheers