Add control for the native stack check with hardware trap #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1wudi
reviewed
Nov 7, 2022
product-mini/platforms/nuttx/wamr.mk
Outdated
| CFLAGS += -DWASM_DISABLE_STACK_HW_BOUND_CHECK=1 | ||
| else | ||
| CFLAGS += -DWASM_DISABLE_HW_BOUND_CHECK=0 | ||
| ifeq ($(CONFIG_INTERPRETERS_WAMR_DISABLE_STACK_HW_BOUND_CHECK),y) |
Collaborator
There was a problem hiding this comment.
No such option in NuttX now，we can disable it if CONFIG_INTERPRETERS_WAMR_DISABLE_HW_BOUND_CHECK disabled.
BTW, even CONFIG_INTERPRETERS_WAMR_DISABLE_HW_BOUND_CHECK exists but it doesn't works actually since most NuttX supported platform don't have MMU.
Collaborator
Author
There was a problem hiding this comment.
OK, just add CFLAGS += -DWASM_DISABLE_STACK_HW_BOUND_CHECK=0 when CONFIG_INTERPRETERS_WAMR_DISABLE_HW_BOUND_CHECK is disabled.
NingW101
pushed a commit
to NingW101/wasm-micro-runtime
that referenced
this pull request
Dec 1, 2022
…liance#1682) Add a new options to control the native stack hw bound check feature: - Besides the original option `cmake -DWAMR_DISABLE_HW_BOUND_CHECK=1/0`, add a new option `cmake -DWAMR_DISABLE_STACK_HW_BOUND_CHECK=1/0` - When the linear memory hw bound check is disabled, the stack hw bound check will be disabled automatically, no matter what the input option is - When the linear memory hw bound check is enabled, the stack hw bound check is enabled/disabled according to the value of input option - Besides the original option `--bounds-checks=1/0`, add a new option `--stack-bounds-checks=1/0` for wamrc Refer to: bytecodealliance#1677
wenyongh
added a commit
that referenced
this pull request
Dec 6, 2022
Add a new options to control the native stack hw bound check feature: - Besides the original option `cmake -DWAMR_DISABLE_HW_BOUND_CHECK=1/0`, add a new option `cmake -DWAMR_DISABLE_STACK_HW_BOUND_CHECK=1/0` - When the linear memory hw bound check is disabled, the stack hw bound check will be disabled automatically, no matter what the input option is - When the linear memory hw bound check is enabled, the stack hw bound check is enabled/disabled according to the value of input option - Besides the original option `--bounds-checks=1/0`, add a new option `--stack-bounds-checks=1/0` for wamrc Refer to: #1677
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…liance#1682) Add a new options to control the native stack hw bound check feature: - Besides the original option `cmake -DWAMR_DISABLE_HW_BOUND_CHECK=1/0`, add a new option `cmake -DWAMR_DISABLE_STACK_HW_BOUND_CHECK=1/0` - When the linear memory hw bound check is disabled, the stack hw bound check will be disabled automatically, no matter what the input option is - When the linear memory hw bound check is enabled, the stack hw bound check is enabled/disabled according to the value of input option - Besides the original option `--bounds-checks=1/0`, add a new option `--stack-bounds-checks=1/0` for wamrc Refer to: bytecodealliance#1677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new options to control the native stack hw bound check feature:
cmake -DWAMR_DISABLE_HW_BOUND_CHECK=1/0,add a new option
cmake -DWAMR_DISABLE_STACK_HW_BOUND_CHECK=1/0will be disabled automatically, no matter what the input option is
is enabled/disabled according to the value of input option
--bounds-checks=1/0, add a new option--stack-bounds-checks=1/0for wamrc