Add wasm_module_obtain() to clone another from one wasm_module_t #1660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6cdcadb to
0ed85ef
Compare
wenyongh
reviewed
Nov 2, 2022
0ed85ef to
2613c9e
Compare
Contributor
|
i guess it's better to introduce wasm_shared_module_t for compatibility. how do you think? |
Contributor
Author
|
Slightly hesitate about the purpose of |
Contributor
|
i'm talking about wasm_shared_module_t specifically, which seems to be used by other implementations. it even appears in an example in wasm-c-api repo: |
wenyongh
reviewed
Nov 8, 2022
2613c9e to
3df1b51
Compare
wenyongh
reviewed
Nov 8, 2022
90fa558 to
867f80b
Compare
wenyongh
reviewed
Nov 8, 2022
b6c56ce to
3c60416
Compare
also support wasm_shared_module_t
3c60416 to
f66dce7
Compare
NingW101
pushed a commit
to NingW101/wasm-micro-runtime
that referenced
this pull request
Dec 1, 2022
Also add support for wasm_shared_module_t, and add lock for wasm_module_t related operations. And add wasm-c-api sample threads, update sample clone.
wenyongh
pushed a commit
that referenced
this pull request
Dec 6, 2022
Also add support for wasm_shared_module_t, and add lock for wasm_module_t related operations. And add wasm-c-api sample threads, update sample clone.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Also add support for wasm_shared_module_t, and add lock for wasm_module_t related operations. And add wasm-c-api sample threads, update sample clone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It depends on #1656