Enable backend threads pre-compilation for orcv2 JIT #1589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge bytecodealliance:dev/refactor_llvm_jit into wenyongh:dev/refactor_llvm_jit
Upgrade to ORCv2 APIs (bytecodealliance#1456)
Merge bytecodealliance:dev/refactor_llvm_jit into wenyongh:dev/refactor_llvm_jit
lum1n0us
reviewed
Oct 14, 2022
lum1n0us
reviewed
Oct 14, 2022
| set_error_buf_v(error_buf, error_buf_size, | ||
| "failed to compile orc jit function: %s", err_msg); | ||
| LLVMDisposeErrorMessage(err_msg); | ||
| bh_print_time("Begin to lookup jit functions"); |
Contributor
There was a problem hiding this comment.
Since CoD creates stub for every function, Lookup will not involve any heavy jobs like compilation or optimization. It may not need to use multiple background thread to do that.
Collaborator
Author
There was a problem hiding this comment.
I did some test, it reduces port of total lookup time, had better add it to startup as quick as we can.
lum1n0us
reviewed
Oct 14, 2022
| module->func_ptrs[i] = (void *)func_addr; | ||
| } | ||
|
|
||
| #if WASM_ENABLE_LAZY_JIT == 0 |
Contributor
There was a problem hiding this comment.
guess we don't need WASM_ENABLE_LAZY_JIT == 0 and join.
Collaborator
Author
There was a problem hiding this comment.
If it is removed, the WASM_ENABLE_LAZY_JIT isn't used, do we want to disable the eager mode?
lum1n0us
reviewed
Oct 14, 2022
lum1n0us
reviewed
Oct 14, 2022
wenyongh
added a commit
to wenyongh/wasm-micro-runtime
that referenced
this pull request
Oct 14, 2022
Enable backend threads pre-compilation for orcv2 JIT (bytecodealliance#1589)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.