fix threads spec test issue #1586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Oct 13, 2022
Comment on lines
346
to
347
| if (address + (wait64 ? 8 : 4) > aot_memory->memory_data_end.ptr) { | ||
| wasm_runtime_set_exception(module, "out of bounds memory access"); |
Collaborator
There was a problem hiding this comment.
Failed to compile on Windows, and should check address < memory_data:
if ((uint8 *)address < (uint8 *)aot_memory->memory_data.ptr
|| (uint8 *)address + (wait64 ? 8 : 4)
> (uint8 *)aot_memory->memory_data_end.ptr) {
wasm_runtime_set_exception(module, "out of bounds memory access");
return -1;
}
Comment on lines
329
to
331
| if ((uint8 *)address + (wait64 ? 8 : 4) | ||
| > module_inst->memories[0]->memory_data_end) { | ||
| wasm_runtime_set_exception(module, "out of bounds memory access"); |
Collaborator
There was a problem hiding this comment.
Should also check whether address < memory_data:
if ((uint8 *)address < module_inst->memories[0]->memory_data
|| (uint8 *)address + (wait64 ? 8 : 4)
> module_inst->memories[0]->memory_data_end) {
wasm_runtime_set_exception(module, "out of bounds memory access");
return -1;
}
Comment on lines
439
to
442
| if ((uint8 *)address + 4 > module_inst->memories[0]->memory_data_end) { | ||
| wasm_runtime_set_exception(module, "out of bounds memory access"); | ||
| return -1; | ||
| } |
Collaborator
There was a problem hiding this comment.
if ((uint8 *)address < module_inst->memories[0]->memory_data
|| (uint8 *)address + 4
> module_inst->memories[0]->memory_data_end) {
wasm_runtime_set_exception(module, "out of bounds memory access");
return -1;
}
Comment on lines
450
to
453
| if (address + 4 > aot_memory->memory_data_end.ptr) { | ||
| wasm_runtime_set_exception(module, "out of bounds memory access"); | ||
| return -1; | ||
| } |
Collaborator
There was a problem hiding this comment.
if ((uint8 *)address < (uint8 *)aot_memory->memory_data.ptr
|| (uint8 *)address + 4
> (uint8 *)aot_memory->memory_data_end.ptr) {
wasm_runtime_set_exception(module, "out of bounds memory access");
return -1;
}
Collaborator
Author
There was a problem hiding this comment.
Done, thanks~
This was referenced Oct 13, 2022
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.