linux-sgx: implement getpeername, recvfrom and sendto. #1556
Conversation
|
Thanks @wenyongh for the thorough feedback! While applying the requested changes, I noticed Furthermore, I have also handled any returned error by Don't hesitate to share any further observations. |
| } | ||
|
|
||
| static int | ||
| sockaddr_to_bh_sockaddr(const struct sockaddr *sockaddr, socklen_t socklen, |
There was a problem hiding this comment.
this is a clone of a function that we have in the posix_socket.c - do you think we can share the code instead of replicating it?
There was a problem hiding this comment.
Yes, maybe we add folder core/shared/platform/common/socket and a file under it to implement sockaddr_to_bh_sockaddr and bh_sockaddr_to_sockaddr. But here SGX only supports AF_INET and bh_sockaddr->is_ipv4, the code is a little different from posix's implementation, I think we can merge this PR firstly and refine the code later.
|
LGTM |
…ecodealliance#1556) Implement some of the popular socket APIs left unimplemented for SGX, following the merge of dev/socket.
Hey,
Nothing crazy here, implemented some of the popular socket APIs left unimplemented for SGX, following the merge of
dev/socket.An orthogonal note to this PR: I notice that
posix_socket.c(the backend of POSIX) now handles the structures for ipv4 and ipv6. A next step would also be to port that adaptation for the POSIX backend of SGX.Cheers