Fix NuttX build after dev/socket merge #1517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16133a1 to
960525a
Compare
loganek
reviewed
Sep 26, 2022
| "CONFIG_INTERPRETERS_WAMR=y\\nCONFIG_INTERPRETERS_WAMR_AOT=y\\nCONFIG_INTERPRETERS_WAMR_FAST=y\\n", | ||
| "CONFIG_INTERPRETERS_WAMR=y\\nCONFIG_INTERPRETERS_WAMR_AOT=y\\nCONFIG_INTERPRETERS_WAMR_CLASSIC=y\\n", | ||
| "CONFIG_INTERPRETERS_WAMR=y\\nCONFIG_INTERPRETERS_WAMR_AOT=y\\nCONFIG_INTERPRETERS_WAMR_LIBC_BUILTIN=y\\n", | ||
| "CONFIG_INTERPRETERS_WAMR=y\\nCONFIG_INTERPRETERS_WAMR_AOT=y\\nCONFIG_INTERPRETERS_WAMR_LIBC_WASI=y\\nCONFIG_NET=y\\nCONFIG_NET_SOLINGER=y\\nCONFIG_NET_TCP=y\\nCONFIG_NET_TCP_WRITE_BUFFERS=y\\nCONFIG_NET_SOCKOPTS=y\\n", |
Contributor
There was a problem hiding this comment.
Could you clarify how the CONFIG_NET* parameters are used? I don't see any reference to them in the source code.
Contributor
Author
There was a problem hiding this comment.
libc-wasi now requires setsockopt etc and thus requires these nuttx options enabled.
Contributor
There was a problem hiding this comment.
Could you point me to a code where those parameters are used? Thank you
Contributor
Author
There was a problem hiding this comment.
they are used in nuttx repo. https://github.com/apache/incubator-nuttx
Contributor
Author
|
i dropped the ci bits for now as it was more complex than i expected. |
loganek
approved these changes
Sep 26, 2022
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.