fix AOT debug for macOS #1494
Merged
fix AOT debug for macOS #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/apache/incubator-nuttx commit 72313301e23f9c2de969fb64b9a0f67bb4c284df I took them from NuttX because they have a compatible license. (Apache 2.0)
While elf.h is commonly avalilable on Linux, it isn't on other platforms like macOS.
11a14ae to
0d09ef1
Compare
wenyongh
reviewed
Sep 16, 2022
| * "License"); you may not use this file except in compliance with the | ||
| * License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 |
Collaborator
There was a problem hiding this comment.
@yamt, when introducing new files from other projects, we used to (1) add a file LICENSE under the related folder, (2) update the <wamr-root>/ATTRIBUTIONS.md to avoid the license issue. Could you do the similar operations? Thanks.
Contributor
Author
There was a problem hiding this comment.
done.
i included their LICENSE/NOTICE files as they are. if it's preferred to strip unrelated parts, please let me know.
Collaborator
There was a problem hiding this comment.
Yes, I found that LINCESE_NUTTX is really long, but we only need the first part, right? Can we only keep the content before L202?
Contributor
Author
There was a problem hiding this comment.
ok. i removed unrelated parts.
ff28b60 to
daf6e53
Compare
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
note: macOS doesn't have elf.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: macOS doesn't have elf.h.