Skip to content

Conversation

@TianlongLiang
Copy link
Contributor

fix Dockerfile linter errors and most warnings

@lum1n0us
Copy link
Contributor

@wenyongh
I am thinking that maybe we should remove ci/Dockerfile and always recommand .devcontainer/Dockerfile.

@wenyongh
Copy link
Collaborator

@wenyongh I am thinking that maybe we should remove ci/Dockerfile and always recommand .devcontainer/Dockerfile.

Yes, if possible, more docker files make more confusing and result in more maintain burden.

@lum1n0us
Copy link
Contributor

@wenyongh We still lefts some software versions relatied warnings. Should we indiciate versions of all dependencies? Or keep using latest ones?

@wenyongh
Copy link
Collaborator

@wenyongh We still lefts some software versions relatied warnings. Should we indiciate versions of all dependencies? Or keep using latest ones?

Not sure, shall we use the latest ones by default, and add some comments to indicate which versions to use if the os is not the latest?

@lum1n0us
Copy link
Contributor

@TianlongLiang

  • please remove ci/Dockerfile, and recommaned vscode development container in documents.
  • please make sure that all references to ci/Dockerfile are handled.

@TianlongLiang
Copy link
Contributor Author

OK, I will get to it.

@lum1n0us
Copy link
Contributor

@wenyongh We still lefts some software versions relatied warnings. Should we indiciate versions of all dependencies? Or keep using latest ones?

Not sure, shall we use the latest ones by default, and add some comments to indicate which versions to use if the os is not the latest?

IIUC,

  • apt-get install will install the package with the latest available version. For example, there is a chance that apt-get will install difference version on Ubuntu 20.04 and Ubuntu 22.04. It depends on which version the package owner uploaded. Usually it dosn't matter since apt-get is so popular that any package problem will be fixed ASAP.
  • pip install is the same story

@TianlongLiang
Copy link
Contributor Author

@TianlongLiang

  • please remove ci/Dockerfile, and recommaned vscode development container in documents.
  • please make sure that all references to ci/Dockerfile are handled.

so for the shell scripts in sample/workload/* and shell script in ci/, I should change the directory of Dockerfile to the one under .devcontainer, right?

@lum1n0us
Copy link
Contributor

@TianlongLiang

  • please remove ci/Dockerfile, and recommaned vscode development container in documents.
  • please make sure that all references to ci/Dockerfile are handled.

so for the shell scripts in sample/workload/* and shell script in ci/, I should change the directory of Dockerfile to the one under .devcontainer, right?

YES. that is the plan. let's see how it goes.

@TianlongLiang
Copy link
Contributor Author

Now I finished modifying the shell scripts ci/build_wamr.sh and samples/workload/docker/build_workload.sh to redirect them to use .devcontainer/Dockerfile, and they ran successfully. And I used this Dockerfile in the vscode, which was also fined.

Also, I tested all the other Dockerfile and can successfully build them except product-mini/platforms/zephyr/simple/Dockerfile. It displays the following error messages when trying to build it even on the original unmodified Dockerfile:

Step 15/18 : RUN west espressif install
 ---> Running in 0e69b119aa3a
usage: west espressif [-h] [-b BAUD] [-p PORT] [-e ELF] {monitor}
west espressif: error: argument command: invalid choice: 'install' (choose from 'monitor')
The command '/bin/sh -c west espressif install' returned a non-zero code: 2

I tried to fix this issue today but so far no luck, I wonder if someone is more familiar with this west command or this zephyr platform that I could ask for help with. Meanwhile, I will continue to work on trying to fix this error

@TianlongLiang TianlongLiang changed the title Dev/upgrade llvm wasi sdk emsdk Dockerfile lint errors fix Sep 20, 2022
@TianlongLiang TianlongLiang force-pushed the dev/upgrade_llvm_wasi_sdk_emsdk branch from 9ddd4f0 to 33cdbae Compare September 20, 2022 05:51
@TianlongLiang TianlongLiang changed the base branch from dev/upgrade_llvm_wasi_sdk_emsdk to main September 20, 2022 05:52
@TianlongLiang TianlongLiang force-pushed the dev/upgrade_llvm_wasi_sdk_emsdk branch from 412f3a7 to 0b4d3c5 Compare September 21, 2022 07:16
@wenyongh wenyongh merged commit ee210d0 into bytecodealliance:main Sep 22, 2022
@TianlongLiang TianlongLiang deleted the dev/upgrade_llvm_wasi_sdk_emsdk branch September 27, 2022 06:28
vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Fix the Dockerfile linter errors and most warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants