-
Notifications
You must be signed in to change notification settings - Fork 749
Dockerfile lint errors fix #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile lint errors fix #1493
Conversation
|
@wenyongh |
Yes, if possible, more docker files make more confusing and result in more maintain burden. |
|
@wenyongh We still lefts some software versions relatied warnings. Should we indiciate versions of all dependencies? Or keep using latest ones? |
Not sure, shall we use the latest ones by default, and add some comments to indicate which versions to use if the os is not the latest? |
|
|
OK, I will get to it. |
IIUC,
|
so for the shell scripts in sample/workload/* and shell script in ci/, I should change the directory of Dockerfile to the one under .devcontainer, right? |
YES. that is the plan. let's see how it goes. |
|
Now I finished modifying the shell scripts Also, I tested all the other Dockerfile and can successfully build them except Step 15/18 : RUN west espressif install
---> Running in 0e69b119aa3a
usage: west espressif [-h] [-b BAUD] [-p PORT] [-e ELF] {monitor}
west espressif: error: argument command: invalid choice: 'install' (choose from 'monitor')
The command '/bin/sh -c west espressif install' returned a non-zero code: 2I tried to fix this issue today but so far no luck, I wonder if someone is more familiar with this |
9ddd4f0 to
33cdbae
Compare
… and resolve those who dependent on it
412f3a7 to
0b4d3c5
Compare
Fix the Dockerfile linter errors and most warnings
fix Dockerfile linter errors and most warnings