Skip to content

Conversation

@loganek
Copy link
Contributor

@loganek loganek commented Sep 6, 2022

@loganek loganek force-pushed the loganek/sendtorecvfrom branch 6 times, most recently from abe88e5 to 29e7b47 Compare September 6, 2022 12:13
@loganek
Copy link
Contributor Author

loganek commented Sep 11, 2022

@wenyongh would you mind having a look at the PR? We're looking to test the changes in dev/socket next week and propose merge to main if all works well. Thanks

@wenyongh
Copy link
Collaborator

wenyongh commented Sep 12, 2022

@wenyongh would you mind having a look at the PR? We're looking to test the changes in dev/socket next week and propose merge to main if all works well. Thanks

No, glad to review the PR, there are only several comments from me, had better also get the review from @lum1n0us.

@loganek loganek force-pushed the loganek/sendtorecvfrom branch from 29e7b47 to c393444 Compare September 12, 2022 13:24
@lum1n0us
Copy link
Contributor

LGTM

@wenyongh wenyongh merged commit b731ca4 into bytecodealliance:dev/socket Sep 13, 2022
wenyongh added a commit that referenced this pull request Sep 22, 2022
Implement more socket APIs, refer to #1336 and below PRs:
- Implement wasi_addr_resolve function (#1319)
- Fix socket-api byte order issue when host/network order are the same (#1327)
- Enhance sock_addr_local syscall (#1320)
- Implement sock_addr_remote syscall (#1360)
- Add support for IPv6 in WAMR (#1411)
- Implement ns lookup allowlist (#1420)
- Implement sock_send_to and sock_recv_from system calls (#1457)
- Added http downloader and multicast socket options (#1467)
- Fix `bind()` calls to receive the correct size of `sockaddr` structure (#1490)
- Assert on correct parameters (#1505)
- Copy only received bytes from socket recv buffer into the app buffer (#1497)

Co-authored-by: Marcin Kolny <mkolny@amazon.com>
Co-authored-by: Marcin Kolny <marcin.kolny@gmail.com>
Co-authored-by: Callum Macmillan <callumimacmillan@gmail.com>
vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Implement more socket APIs, refer to bytecodealliance#1336 and below PRs:
- Implement wasi_addr_resolve function (bytecodealliance#1319)
- Fix socket-api byte order issue when host/network order are the same (bytecodealliance#1327)
- Enhance sock_addr_local syscall (bytecodealliance#1320)
- Implement sock_addr_remote syscall (bytecodealliance#1360)
- Add support for IPv6 in WAMR (bytecodealliance#1411)
- Implement ns lookup allowlist (bytecodealliance#1420)
- Implement sock_send_to and sock_recv_from system calls (bytecodealliance#1457)
- Added http downloader and multicast socket options (bytecodealliance#1467)
- Fix `bind()` calls to receive the correct size of `sockaddr` structure (bytecodealliance#1490)
- Assert on correct parameters (bytecodealliance#1505)
- Copy only received bytes from socket recv buffer into the app buffer (bytecodealliance#1497)

Co-authored-by: Marcin Kolny <mkolny@amazon.com>
Co-authored-by: Marcin Kolny <marcin.kolny@gmail.com>
Co-authored-by: Callum Macmillan <callumimacmillan@gmail.com>
@loganek loganek deleted the loganek/sendtorecvfrom branch June 10, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants