debug-engine: Handle wasm_debug_instance_get_current_object_name failure #1453
Conversation
Use an empty string instead of stack garbage.
| if (!wasm_debug_instance_get_current_object_name( | ||
| (WASMDebugInstance *)server->thread->debug_instance, objname, | ||
| 128)) { | ||
| objname[0] = 0; /* use an empty string */ |
There was a problem hiding this comment.
How about zero initialize the buffer at L110： char objname[128] = { 0 };
And how about set to nobody.wasm if get object name failed?
There was a problem hiding this comment.
How about zero initialize the buffer at L110： char objname[128] = { 0 };
i don't like it because it assumes more about the implementation of wasm_debug_instance_get_current_object_name.
And how about set to nobody.wasm if get object name failed?
why? it looks like an ordinary name. does lldb handle it specially?
There was a problem hiding this comment.
i don't like it because it assumes more about the implementation of wasm_debug_instance_get_current_object_name.
Ok, agree with you.
why? it looks like an ordinary name. does lldb handle it specially?
No, lldb doesn't handle it specially. Just because we use this string for LIBC_BUILTIN mode.
Empty string also OK to me.
|
LGTM |
…ure (bytecodealliance#1453) Use an empty string instead of stack garbage.
Use an empty string instead of stack garbage.