Fix potential warning of printf in posix/main.c #1440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
wenyongh
reviewed
Sep 1, 2022
| uint32 major, minor, patch; | ||
| wasm_runtime_get_version(&major, &minor, &patch); | ||
| printf("iwasm %u.%u.%u\n", major, minor, patch); | ||
| printf("iwasm %" PRIu32 ".%" PRIu32 ".%" PRIu32 "\n", major, minor, |
Collaborator
There was a problem hiding this comment.
There are some other places, shall we modify them also?
wamr-compiler/main.c
product-mini/platforms/windows/main.c
product-mini/platforms/linux-sgx/enclave-sample/App/App.cpp
Collaborator
Author
There was a problem hiding this comment.
It seems some PRIxxx macro is not available in sgx enclave ?
Collaborator
There was a problem hiding this comment.
Yes, seems not supported. Let's merge this PR firstly.
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.