-
Notifications
You must be signed in to change notification settings - Fork 749
Fix bugs: No error was detected and returned after the instruction or register generation failed. #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use pointer comparison instead of struct memory comparison. When using call_indirect, type comparison is required. I optimized the speed of type comparison, and changed type structure memory comparison to pointer comparison.
whitch stores the number of type references
in wasm_interp_fast.c and wasm_interp_classic.c
when "globals" initialization fails, the memory allocated is not released, resulting in memory leakage
…der.c." This reverts commit cf45ba4.
after initialize a compilation context for fast jit failed.
when calling jit_cc_new_reg_I64 in jit_compile_op_i32_load.
|
Not sure this is a real bug. If a process can not allocate such small memory resource, like 10 bytes or 20 bytes, I am afraid the whole system can not respond to anything and there is nothing we can do unless rebooting. IIUC, to catch all failed |
@lum1n0us |
Add more checks for Fast JIT to fix the issues reported by instrument test: - add check for the jit_value before pushing it into the stack - add check at the end of form_and_translate_func - add checks after each jit pass
In some function, like form_and_translate_func, when the micro GEN_INSN or other insn or reg generation function failed, we ignore to detect error and return false.