Add a new API to get free mem in mempool #1430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Aug 30, 2022
core/iwasm/common/wasm_memory.c
Outdated
| } | ||
|
|
||
| extern void * | ||
| gc_heap_stats(void *heap, uint32 *stats, int size); |
Collaborator
There was a problem hiding this comment.
Not a good coding custom, had better implement the API in mem alloc layer, how about:
define struct and implement API in core/shared/mem-alloc/mem_alloc.{hc}:
typedef struct mem_alloc_info_t {
uint32_t total_size;
uint32_t total_free_size;
uint32_t highmark_size;
} mem_alloc_info_t;
bool
mem_allocator_get_alloc_info(mem_allocator_t allocator, mem_alloc_info_t *mem_alloc_info);
Collaborator
Author
There was a problem hiding this comment.
This typedef is dupped with wasm_export.h
Collaborator
There was a problem hiding this comment.
How about using a macro to control it (like MEM_ALLOC_OPTION_DEFINED): in wasm_export.h and mem_alloc.h, add:
#ifndef MEM_ALLOC_INFO_DEFINED
#define MEM_ALLOC_INFO_DEFINED
typedef struct mem_alloc_info_t {
uint32_t total_size;
uint32_t total_free_size;
uint32_t highmark_size;
} mem_alloc_info_t;
#endif
core/iwasm/common/wasm_memory.c
Outdated
| extern void * | ||
| gc_heap_stats(void *heap, uint32 *stats, int size); | ||
|
|
||
| int |
Collaborator
There was a problem hiding this comment.
Had better return bool, like other APIs in wasm_export.h
core/iwasm/common/wasm_memory.c
Outdated
| wasm_runtime_mallinfo(mem_mallinfo_t *mall) | ||
| { | ||
| if (memory_mode == MEMORY_MODE_POOL) { | ||
| gc_heap_stats(pool_allocator, mall->info, 3); |
Collaborator
There was a problem hiding this comment.
return mem_allocator_get_alloc_info(pool_allocator, mem_alloc_info);
core/iwasm/include/wasm_export.h
Outdated
Comment on lines
125
to
134
| typedef union { | ||
| struct { | ||
| uint32_t info[3]; | ||
| }; | ||
| struct { | ||
| uint32_t total_size; | ||
| uint32_t total_free_size; | ||
| uint32_t highmark_size; | ||
| }; | ||
| } mem_mallinfo_t; |
Collaborator
There was a problem hiding this comment.
How about:
typedef struct mem_alloc_info_t {
uint32_t total_size;
uint32_t total_free_size;
uint32_t highmark_size;
} mem_alloc_info_t;
core/iwasm/include/wasm_export.h
Outdated
| * Get memory info, only pool mode supported now. | ||
| */ | ||
| WASM_RUNTIME_API_EXTERN int | ||
| wasm_runtime_mallinfo(mem_mallinfo_t *mall); |
Collaborator
There was a problem hiding this comment.
How about
WASM_RUNTIME_API_EXTERN bool
wasm_runtime_get_mem_alloc_info(mem_alloc_info_t *mem_alloc_info);d51f3ca to
b5b5ad1
Compare
wenyongh
reviewed
Aug 30, 2022
core/iwasm/common/wasm_memory.c
Outdated
| #include "wasm_runtime_common.h" | ||
| #include "bh_platform.h" | ||
| #include "mem_alloc.h" | ||
| #include "ems/ems_gc.h" |
Collaborator
There was a problem hiding this comment.
No need to include ems_gc.h
core/iwasm/common/wasm_memory.c
Outdated
| { | ||
| if (memory_mode == MEMORY_MODE_POOL) { | ||
| return mem_allocator_get_alloc_info(pool_allocator, mem_alloc_info); | ||
| return true; |
core/iwasm/include/wasm_export.h
Outdated
| wasm_runtime_free(void *ptr); | ||
|
|
||
| /* | ||
| * Get memory info, only pool mode supported now. |
Collaborator
There was a problem hiding this comment.
Had better change supported to is supported
Signed-off-by: Huang Qi <huangqi3@xiaomi.com> Change-Id: I4c825661fbcc8208b9c6c6b4668ef2fb8836087e
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
wenyongh
added a commit
to wenyongh/wasm-micro-runtime
that referenced
this pull request
Aug 31, 2022
Add a new API to get free memory in memory pool (bytecodealliance#1430)
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.