Enable memory leak check #1429
Enable memory leak check #1429
Conversation
Merge bytecodealliance:main into wenyongh:enable_mem_leak_check
| && (hmu_t *)((char *)cur + hmu_get_size(cur)) != end) { | ||
| os_printf("Memory leak detected:\n"); | ||
| gci_dump(heap); | ||
| #if WASM_ENABLE_SPEC_TEST != 0 |
There was a problem hiding this comment.
Can we add a config BH_EXIT_ON_GC_VERIFY_ERROR and exit(-1) here when it is enabled? This will be more friendly to instrumentation test framework
There was a problem hiding this comment.
Yes, will the return value -1 be gotten by the runtime embedder?
There was a problem hiding this comment.
Yes, will the return value -1 be gotten by the runtime embedder?
the -1 will be the exit code of the process and will be gotten by another process (instrument daemon server)
There was a problem hiding this comment.
Add the exit(-1) in wasm_runtime_memory_destroy(), wasm_memory.c, for global heap only. As wasm app heap also uses ems gc, if it has memory leak, it will exit firstly, the global heap memory leak check will be ignored.
product-mini/platforms/posix/main.c
Outdated
| #if WASM_ENABLE_GLOBAL_HEAP_POOL != 0 | ||
| #ifdef __NuttX__ | ||
| static char global_heap_buf[WASM_GLOBAL_HEAP_SIZE * BH_KB] = { 0 }; | ||
| #elif WASM_ENABLE_SPEC_TEST != 0 |
There was a problem hiding this comment.
How about merge these three definitions into one and define a platform dependent size (WASM_GLOBAL_HEAP_SIZE) for it ?
There was a problem hiding this comment.
Done, I defined the WASM_GLOBAL_HEAP_SIZE with unit bytes but not KB, is it OK for Nuttx?
There was a problem hiding this comment.
It's better to change
together to get correct heap pool size.There was a problem hiding this comment.
How to change, like this?
CFLAGS += -DWASM_GLOBAL_HEAP_SIZE="$(CONFIG_INTERPRETERS_WAMR_GLOBAL_HEAP_POOL_SIZE) * 1024" Merge bytecodealliance:main into wenyongh:enable_mem_leak_check
Report the memory leak info when building iwasm with `cmake .. -DWAMR_BUILD_GC_VERIFY=1`
Report the memory leak info when building iwasm with
cmake .. -DWAMR_BUILD_GC_VERIFY=1.