debug-engine: allocate "tmpbuf" dynamically #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Aug 26, 2022
| return BHT_ERROR; | ||
| } | ||
| int ret = os_mutex_init(&tmpbuf_lock); | ||
| if (ret == BHT_ERROR) { |
Collaborator
There was a problem hiding this comment.
Had better use ret != BHT_SUCCESS
| if (tmpbuf == NULL) { | ||
| return BHT_ERROR; | ||
| } | ||
| int ret = os_mutex_init(&tmpbuf_lock); |
Collaborator
There was a problem hiding this comment.
Had better define ret at the beginning of the function
Some configurations (eg. esp32/nuttx) have limited space for BSS. 0x20000 byte buffer is huge on embedded systems. I guess in general malloc heap tends to have less limitations. And probably more importantly, this change makes it allocated only when the feature (debug engine) is actually used.
| { | ||
| return os_mutex_init(&tmpbuf_lock); | ||
| int ret; | ||
| tmpbuf = wasm_runtime_malloc(MAX_PACKET_SIZE); |
Collaborator
There was a problem hiding this comment.
On some constraint devices, there is a great possibility of malloc failure for such a large space, had better add LOG_ERROR("Allocate debug package buffer failed");, otherwise the developer may not know what happened
Contributor
Author
There was a problem hiding this comment.
done.
btw, do you (or anyone) remember why this huge buffer is allocated here?
is it somehow required by the protocol?
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Some configurations (eg. esp32/nuttx) have limited space for BSS, 0x20000 byte buffer is huge on embedded systems, change to allocate the buffer dynamically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some configurations (eg. esp32/nuttx) have limited space for BSS.
0x20000 byte buffer is huge on embedded systems.
I guess in general malloc heap tends to have less limitations.
And probably more importantly, this change makes it allocated only
when the feature (debug engine) is actually used.