wasm_application.c: Do not start debug instance automatically #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-mini/platforms/posix/main.c
Outdated
| printf("%s\n", wasm_runtime_get_exception(wasm_module_inst)); | ||
| goto fail4; | ||
| } | ||
| uint32_t debug_port = wasm_runtime_start_debug_instance(exec_env); |
Collaborator
There was a problem hiding this comment.
Had better declare variables at the beginning of a scope, otherwise some compiler with C90 may complain
| printf("%s\n", wasm_runtime_get_exception(wasm_module_inst)); | ||
| goto fail4; | ||
| } | ||
| uint32_t debug_port = wasm_runtime_start_debug_instance(exec_env); |
It's better to leave the control to embedders. (eg. product-mini) background: I have a use case where * The application runs multiple module instances. * I want to debug only one of them.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…dealliance#1407) Leave the control from wasm_application_execute_main to host embedders, eg. product-mini.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's better to leave the control to embedders. (eg. product-mini)
background: I have a use case where