Skip to content

Conversation

@yamt
Copy link
Contributor

@yamt yamt commented Aug 19, 2022

It's unused since the following commit.

commit 260d36a62da58aa8d59fbad61db678d938ab529f
Author: Wenyong Huang <wenyong.huang@intel.com>
Date:   Wed Jan 19 11:25:08 2022 +0800

    Refactor externref related APIs of reference types feature (#971)

    Currently when calling wasm_runtime_call_wasm() to invoke wasm function
    with externref type argument from runtime embedder, developer needs to
    use wasm_externref_obj2ref() to convert externref obj into an internal ref
    index firstly, which is not convenient to developer.
    To align with GC feature in which all the references passed to
    wasm_runtime_call_wasm() can be object pointers directly, we change the
    interface of wasm_runtime_call_wasm() to allow to pass object pointer
    directly for the externref argument, and refactor the related codes, update
    the related samples and the document.

It's unused since the following commit.
```
commit 260d36a
Author: Wenyong Huang <wenyong.huang@intel.com>
Date:   Wed Jan 19 11:25:08 2022 +0800

    Refactor externref related APIs of reference types feature (bytecodealliance#971)

    Currently when calling wasm_runtime_call_wasm() to invoke wasm function
    with externref type argument from runtime embedder, developer needs to
    use wasm_externref_obj2ref() to convert externref obj into an internal ref
    index firstly, which is not convenient to developer.
    To align with GC feature in which all the references passed to
    wasm_runtime_call_wasm() can be object pointers directly, we change the
    interface of wasm_runtime_call_wasm() to allow to pass object pointer
    directly for the externref argument, and refactor the related codes, update
    the related samples and the document.
```
@wenyongh wenyongh merged commit 0ec99e9 into bytecodealliance:main Aug 19, 2022
loganek pushed a commit to loganek/wasm-micro-runtime that referenced this pull request Aug 31, 2022
vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants