nuttx: Provide a default WASM_STACK_GUARD_SIZE #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unbreak builds with a bit older nuttx/apps for now. Note: The default value here (0) was chosen to match the new default in nuttx/apps, which is different from the old value used before the introduction of WASM_STACK_GUARD_SIZE. (1024)
Collaborator
|
Is there any build break on older version of NuttX ? |
Contributor
Author
i prefer to be consistent with the value used by new version:
yes. something like the following. |
no1wudi
approved these changes
Aug 15, 2022
loganek
pushed a commit
to loganek/wasm-micro-runtime
that referenced
this pull request
Aug 31, 2022
Unbreak builds with a bit older nuttx/apps for now. Note: The default value here (0) was chosen to match the new default in nuttx/apps, which is different from the old value used before the introduction of WASM_STACK_GUARD_SIZE. (1024)
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Unbreak builds with a bit older nuttx/apps for now. Note: The default value here (0) was chosen to match the new default in nuttx/apps, which is different from the old value used before the introduction of WASM_STACK_GUARD_SIZE. (1024)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbreak builds with a bit older nuttx/apps for now.
Note: The default value here (0) was chosen to match the new default
in nuttx/apps, which is different from the old value used before
the introduction of WASM_STACK_GUARD_SIZE. (1024)