reserve one pointer size for fast-interp compiled_code_size #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Aug 12, 2022
core/iwasm/interpreter/wasm_loader.c
Outdated
| p = func->code; | ||
| func->code_compiled = loader_ctx->p_code_compiled; | ||
| func->code_compiled_size = loader_ctx->code_compiled_size; | ||
| func->code_compiled_size = loader_ctx->code_compiled_peak_size; |
Collaborator
There was a problem hiding this comment.
func->code_compiled_size is used by wasm_runtime wasm_get_func_code_end() function, which might impact the frame_ip_end in wasm_interp_fast.c and the interpreter's behavior? Do we need to change it here?
Collaborator
Author
There was a problem hiding this comment.
Yes, I modified it back, but the shortcoming is the memory profiler may not be so accurate
Collaborator
There was a problem hiding this comment.
OK, no need to be so accurate for memory profiler, this almost doesn't occur except few few case.
loganek
pushed a commit
to loganek/wasm-micro-runtime
that referenced
this pull request
Aug 31, 2022
…alliance#1382) Reserve one pointer size for fast-interp code_compiled_size: if the last opcode of current function is to be dropped (e.g. OP_DROP), the peak memory usage will be larger than the final code_compiled_size, we record the peak size to ensure there won't be invalid memory access during the second traversing.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…alliance#1382) Reserve one pointer size for fast-interp code_compiled_size: if the last opcode of current function is to be dropped (e.g. OP_DROP), the peak memory usage will be larger than the final code_compiled_size, we record the peak size to ensure there won't be invalid memory access during the second traversing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.