Interp/Fast-JIT optimization #1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
reviewed
Aug 12, 2022
lum1n0us
reviewed
Aug 12, 2022
lum1n0us
reviewed
Aug 12, 2022
wenyongh
reviewed
Aug 12, 2022
Use pointer comparison instead of struct memory comparison. When using call_indirect, type comparison is required. I optimized the speed of type comparison, and changed type structure memory comparison to pointer comparison.
wenyongh
reviewed
Aug 12, 2022
core/iwasm/interpreter/wasm_loader.c
Outdated
| return node->str; | ||
| } | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Should also apply same changes to wasm_mini_loader.c, which can be compiled with 'cmake -DWAMR_BUILD_MINI_LOADER=1`.
wenyongh
reviewed
Aug 15, 2022
whitch stores the number of type references
in wasm_interp_fast.c and wasm_interp_classic.c
when "globals" initialization fails, the memory allocated is not released, resulting in memory leakage
wenyongh
reviewed
Aug 18, 2022
loganek
pushed a commit
to loganek/wasm-micro-runtime
that referenced
this pull request
Aug 31, 2022
Normalize wasm types, for the two wasm types, if their parameter types and result types are the same, we only save one copy, so as to reduce the footprint and simplify the type comparison in opcode CALL_INDIRECT. And fix issue in interpreter globals_instantiate, and remove used codes.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Normalize wasm types, for the two wasm types, if their parameter types and result types are the same, we only save one copy, so as to reduce the footprint and simplify the type comparison in opcode CALL_INDIRECT. And fix issue in interpreter globals_instantiate, and remove used codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refine wasm_type_equal for call_indirect for intel internal #402
To Wenyong for code review, there is a bug in code and it cannot pass the case of spec (call_indirect.wast) while using these parameters:
Build iwasm with compile flags with-DWAMR_BUILD_TARGET=X86_64-DWAMR_BUILD_INTERP=0-DWAMR_BUILD_FAST_INTERP=0-DWAMR_BUILD_JIT=1-DWAMR_BUILD_AOT=1-DWAMR_BUILD_SPEC_TEST=1-DWAMR_BUILD_BULK_MEMORY=1-DWAMR_BUILD_MULTI_MODULE=0-DWAMR_BUILD_REF_TYPES=1-DWAMR_BUILD_SIMD=0 for spec testNamespace(aot_flag=False, cases=[], clean_up_flag=True, gc_flag=False, multi_module_flag=False, multi_thread_flag=False, parl_flag=False, sgx_flag=False, simd_flag=False, target='X86_64', verbose_flag=True, xip_flag=False)`