Fix windows thread data issue and enhance windows os_mmap #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganek
pushed a commit
to loganek/wasm-micro-runtime
that referenced
this pull request
Aug 31, 2022
…liance#1372) Thread data should not be destroyed when thread exits, or other thread may not be able to join it. This PR saves the thread data into thread data list when thread exits, sets thread status and stores the return value, so that other thread can join it. Also set MEM_TOP_DOWN flag for Windows VirtualAlloc to yield LLVM JIT relocation error. And set opt/size level to 3 for LLVM JIT for future use, currently the flags are not used by LLVM JIT.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…liance#1372) Thread data should not be destroyed when thread exits, or other thread may not be able to join it. This PR saves the thread data into thread data list when thread exits, sets thread status and stores the return value, so that other thread can join it. Also set MEM_TOP_DOWN flag for Windows VirtualAlloc to yield LLVM JIT relocation error. And set opt/size level to 3 for LLVM JIT for future use, currently the flags are not used by LLVM JIT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread data should not be destroyed when thread exits, or other thread
may not be able to join it. This PR saves the thread data into thread data
list when thread exits, sets thread status and stores the return value, so
that other thread can join it.
Also set MEM_TOP_DOWN flag for Windows VirtualAlloc to yield LLVM
JIT relocation error.
And set opt/size level to 3 for LLVM JIT for future use, currently the flags
are not used by LLVM JIT.