-
Notifications
You must be signed in to change notification settings - Fork 749
Support custom stack guard size #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: I2b859d242eb3fa41bdd2683b20951ff400e9a856
…Y to WASM_STACK_GUARD_SIZE
|
Just a little confused about the meaning of when
|
|
@lum1n0us In current implementation, I think |
Some platforms doesn't provide the related API to get native stack boundary, |
|
in that case, such a comparison looks a little wired. It will be passed but ... // if (&module_inst < NULL)
if ((uint8 *)&module_inst < exec_env->native_stack_boundary) {
aot_set_exception_with_id(module_inst, EXCE_NATIVE_STACK_OVERFLOW);
return false;
}Would one of the below be better?
|
No need to do that, if exec_env->native_stack_boundary is NULL, this condition |
Add a new option WAMR_BUILD_STACK_GUARD_SIZE to set the custom stack guard size. For most RTOS systems, we use the native stack base address as the check boundary which may be not safe as POSIX based systems (like Linux).
Add a new option WAMR_BUILD_STACK_GUARD_SIZE to set the custom stack guard size. For most RTOS systems, we use the native stack base address as the check boundary which may be not safe as POSIX based systems (like Linux).
Add a new option
WAMR_BUILD_STACK_GUARD_SIZEto use custom stack guard size,for most RTOS port, we use stack base as check boundry which may not safety as POSIX based system (like linux).