[bugfix] initialize "module->retain_function" for wasm_mini_loader #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before resolving the module function's export in wasm_mini_loader, "module->retain_function" need to be initialized, otherwise, the "__new" function export will lead to abort. issue: bytecodealliance#1332
Contributor
Author
|
The failing cases seem unrelated to this commit, PTAL @wenyongh @XuJun2019 @xwang98 |
Collaborator
|
LGTM |
loganek
pushed a commit
to loganek/wasm-micro-runtime
that referenced
this pull request
Jul 28, 2022
…ytecodealliance#1333) Before resolving the module function's export in wasm_mini_loader, "module->retain_function" need to be initialized, otherwise, the "__new" function export will lead to abort. issue: bytecodealliance#1332 Co-authored-by: yaozhongxiao <yaozhongxiao@bytedance.com>
loganek
pushed a commit
to loganek/wasm-micro-runtime
that referenced
this pull request
Aug 31, 2022
…ytecodealliance#1333) Before resolving the module function's export in wasm_mini_loader, "module->retain_function" need to be initialized, otherwise, the "__new" function export will lead to abort. issue: bytecodealliance#1332 Co-authored-by: yaozhongxiao <yaozhongxiao@bytedance.com>
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ytecodealliance#1333) Before resolving the module function's export in wasm_mini_loader, "module->retain_function" need to be initialized, otherwise, the "__new" function export will lead to abort. issue: bytecodealliance#1332 Co-authored-by: yaozhongxiao <yaozhongxiao@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before resolving the module function's export in wasm_mini_loader,
"module->retain_function" need to be initialized, otherwise,
the "__new" function export will lead to abort.
issue: #1332