Temporarily disable LoopUnswitch pass #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Now against a better branch :) |
c5f11bb to
4d8a6e6
Compare
Disable LoopUnswitch pass for LLVM 15 - C binding has been removed and binding for new pass hasn't been added. Need to reenable when binding gets added to LLVM or when we implement it in WAMR.
4d8a6e6 to
e1443e5
Compare
Contributor
Author
|
I've proposed adding the binding: https://reviews.llvm.org/D127323, if that effort falls through, I'll add it internally. |
wenyongh
added a commit
to wenyongh/wasm-micro-runtime
that referenced
this pull request
Jun 9, 2022
…dk_emsdk Temporarily disable LoopUnswitch pass (bytecodealliance#1183)
wenyongh
pushed a commit
that referenced
this pull request
Jul 29, 2022
Since legacy binding for loop unswitch pass was removed and we can't get it back. Implement its equivalent in `aot_llvm_extra.cpp` and use it in `aot_compiler.c`. Follow up to #1183.
loganek
pushed a commit
to loganek/wasm-micro-runtime
that referenced
this pull request
Aug 31, 2022
Since legacy binding for loop unswitch pass was removed and we can't get it back. Implement its equivalent in `aot_llvm_extra.cpp` and use it in `aot_compiler.c`. Follow up to bytecodealliance#1183.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Since legacy binding for loop unswitch pass was removed and we can't get it back. Implement its equivalent in `aot_llvm_extra.cpp` and use it in `aot_compiler.c`. Follow up to bytecodealliance#1183.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary disable LoopUnswitch in
apply_func_passes(), based on LLVM version. Need to reenable when binding for new loop unswitch pass gets added or the binding is implemented internally.