impl of call_indirect #1138
Merged
impl of call_indirect #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
May 3, 2022
| goto fail; | ||
| } | ||
|
|
||
| argv = pack_argv(cc); |
Collaborator
There was a problem hiding this comment.
Should check return value
Contributor
Author
There was a problem hiding this comment.
pack_argv uses the return value of jit_cc_new_reg_ptr, which we use directly.
| } | ||
|
|
||
| static JitReg | ||
| pack_argv(JitCompContext *cc) |
Collaborator
There was a problem hiding this comment.
Not easy to understand what pack_argv/unpack_argv means.
How about changing pack_argv to get_outs_area? And changing unpack_argv to get_results_from_outs_area?
Contributor
Author
There was a problem hiding this comment.
use pack to describe the act of packaging all parameters into an array, and unpack is the opposite.
5bdfdb0 to
91917f5
Compare
wenyongh
added a commit
to wenyongh/wasm-micro-runtime
that referenced
this pull request
May 7, 2022
Implement JIT IR translation for opcode call_indirect (bytecodealliance#1138)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.