Re-enable FreeBSD CI#643
Merged
sunfishcode merged 2 commits intobytecodealliance:mainfrom Apr 29, 2023
Merged
Conversation
Member
|
Thanks! |
sunfishcode
added a commit
that referenced
this pull request
Jul 2, 2023
* Use `weakcall` for `eventfd` on FreeBSD. `eventfd` was introduced in FreeBSD 13, so it isn't in FreeBSD 12. Use `weakcall` to call it on FreeBSD so that we don't have a link-time dependency on it. Fixes #716. * Re-introduce FreeBSD 12 in the Cirrus CI config. FreeBSD 12 was origally removed in #517 due to problems with `curl`, however those were fixed by removing the `pkg install -y curl` in #643, so we can now re-enable FreeBSD 12 testing. * Use `weakcall!` for `ptsname_r` on FreeBSD too. FreeBSD 12 lacks `ptsname_r`. * Relax a test to accept `NOSYS` from `eventfd` on FreeBSD. * Relax some `procctl` tests on FreeBSD too. * Fix the `openpty` tests for FreeBSD 12.
sunfishcode
added a commit
that referenced
this pull request
Jul 2, 2023
* Use `weakcall` for `eventfd` on FreeBSD. `eventfd` was introduced in FreeBSD 13, so it isn't in FreeBSD 12. Use `weakcall` to call it on FreeBSD so that we don't have a link-time dependency on it. Fixes #716. * Re-introduce FreeBSD 12 in the Cirrus CI config. FreeBSD 12 was origally removed in #517 due to problems with `curl`, however those were fixed by removing the `pkg install -y curl` in #643, so we can now re-enable FreeBSD 12 testing. * Use `weakcall!` for `ptsname_r` on FreeBSD too. FreeBSD 12 lacks `ptsname_r`. * Relax a test to accept `NOSYS` from `eventfd` on FreeBSD. * Relax some `procctl` tests on FreeBSD too. * Fix the `openpty` tests for FreeBSD 12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #600 and fixes FreeBSD CI failure.
curlis already installed in the FreeBSD image. So removing the installation ofcurlfixes the problem.