Skip to content

Add O_DIRECT flag#527

Merged
sunfishcode merged 1 commit intobytecodealliance:mainfrom
jordanisaacs:o-direct
Jan 30, 2023
Merged

Add O_DIRECT flag#527
sunfishcode merged 1 commit intobytecodealliance:mainfrom
jordanisaacs:o-direct

Conversation

@jordanisaacs
Copy link
Contributor

Added the O_DIRECT flag. Not sure if there was a reason for not having it included.

@sunfishcode
Copy link
Member

Thanks! Could you also add O_DIRECT to the libc backend, in src/backend/libc/fs/types.rs? It looks like it's available on at least Linux, Android, Emscripten, FreeBSD, NetBSD, and Fuchsia.

Also, the x86_64-unknown-freebsd-13 CI failure here is unrelated so we can ignore that here.

@jordanisaacs
Copy link
Contributor Author

Added in the libc backend @sunfishcode

@sunfishcode
Copy link
Member

Thanks!

@sunfishcode sunfishcode merged commit 4d0890c into bytecodealliance:main Jan 30, 2023
sunfishcode pushed a commit that referenced this pull request Feb 3, 2023
sunfishcode pushed a commit that referenced this pull request Feb 3, 2023
sunfishcode pushed a commit that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants