fix: ensure pending packets are not lost on EventLoop::clean#780
Merged
Conversation
swanandx
reviewed
Jan 1, 2024
de-sh
added a commit
that referenced
this pull request
Jan 4, 2024
…n` (#780) BREAKING: `EventLoop.pending` uses a `VecDeque` instead of `IntoIter` * fix: use `Vec::extend` to not lost pending * refactor: remove unnecessary unwrap * style: clippy suggestions * doc: note unchecked growth of pending * fix: `VecDeque` preserves ordering Also reverts 8406c4c * doc: note for `EventLoop::clean` * fix: same bug in `mod v5` * doc: add changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Situation earlier:
EventLoophas pending packets yet to be processed.EventLoop::cleanis called.EventLoop::pollhas lost some packets which were earlier pending.This can be solved with a queue in place of the pending iter.
Type of change
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why. (Do we need to do this when the release hasn't been made yet?)