Skip to content

Builder pattern for constructing Link#659

Merged
swanandx merged 4 commits intomainfrom
link-builder
Jul 21, 2023
Merged

Builder pattern for constructing Link#659
swanandx merged 4 commits intomainfrom
link-builder

Conversation

@swanandx
Copy link
Contributor

@swanandx swanandx commented Jul 11, 2023 •
edited
Loading

Support for constructing LinkRx/LinkTx using LinkBuidler.

let (link_tx, link_rx, notification) = LinkBuilder::new(&client_id, router_tx)
    .tenant_id(tenant_id) // None by default
    .clean_session(clean_session) // true by default
    .last_will(lastwill) // None by default
    .dynamic_filters(dynamic_filters) // false by default
    .topic_alias_max(topic_alias_max) // 0 by default
    .build()?;

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if its relevant of user of the library. If its not relevant mention why.

mnpw
mnpw reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@mnpw mnpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks 🚀🚀🚀

please merge after addressing the comments

@swanandx swanandx merged commit cea0d8b into main Jul 21, 2023
@swanandx swanandx deleted the link-builder branch July 21, 2023 11:15
carlocorradini pushed a commit to carlocorradini/rumqtt that referenced this pull request Aug 3, 2023
@swanandx
Builder pattern for constructing Link (bytebeamio#659)
25093ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mnpw mnpw mnpw left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swanandx @mnpw